Skip to content

Collect scene nodes recursively#224

Open
schell wants to merge 5 commits intomainfrom
collect_scene_nodes_recursively
Open

Collect scene nodes recursively#224
schell wants to merge 5 commits intomainfrom
collect_scene_nodes_recursively

Conversation

@schell
Copy link
Owner

@schell schell commented Mar 18, 2026

Addresses PR comments on #217 .

Closes #217

@schell schell marked this pull request as ready for review March 18, 2026 18:31
m0ppers and others added 4 commits March 19, 2026 11:33
…scene

Split the scene node query API into two explicit methods:

- root_nodes_in_scene: returns only the top-level nodes directly
  referenced by the scene (the original behavior)
- recursive_nodes_in_scene: returns all nodes including descendants
  in depth-first order

This fixes a bug where animations targeting child (parented) nodes
were silently skipped because only root nodes were collected.

Update call sites:
- Animator test now uses recursive_nodes_in_scene for correctness
- Example crate simplified by removing manual get_children helper

Co-authored-by: Andreas Streichardt <andreas@mop.koeln>
@schell schell force-pushed the collect_scene_nodes_recursively branch from f955efb to a53ba23 Compare March 18, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants