Conversation
schell
force-pushed
the
feature/shadow-mapping
branch
from
b2d0be9 to
52756b0
Compare
schell
commented
Feb 14, 2025
| // can roughly get candelas from lux by dividing by 683 [2]. | ||
| // 1. https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Khronos/KHR_lights_punctual/README.md | ||
| // 2. https://depts.washington.edu/mictech/optics/me557/Radiometry.pdf | ||
| intensity: intensity / 683.0, |
Owner
Author
There was a problem hiding this comment.
This change has affected the stag::gltf_support::test::normal_mapping_brick_sphere test.
Owner
Author
There was a problem hiding this comment.
Expectedly, multiplying the intensity by 683.0 fixes the test, so no biggy.
schell
force-pushed
the
feature/shadow-mapping
branch
from
2f1fba8 to
c9aadda
Compare
* lighting bindgroup
* initial shadow mapping API in place
* pin cargo gpu
* lots of bug fixes in the shadow mapping path
* more debugging shadow mapping
* can programmatically capture gpu traces, ugly shadows are working
* added configurable bias to shadow mapping
* shadow mapping culls front face to cut down peter panning
* 1 Cargo Files:
• Cargo.lock and Cargo.toml have been updated to change the version of the
craballoc dependency from 0.1.3 to 0.1.5.
2 Example Crate:
• crates/example/src/lib.rs has been modified to update the lighting and shadow
mapping logic, including changes to how shadow maps are created and used.
3 Shaders:
• Several shader files (.spv and .wgsl) have binary differences, indicating
updates to the compiled shader code.
4 Renderling Crate:
• Multiple files in the crates/renderling/src directory have been updated,
including atlas.rs, atlas/atlas_image.rs, atlas/cpu.rs, context.rs,
draw/cpu.rs, lib.rs, light.rs, light/cpu.rs, math.rs, pbr.rs, stage.rs, and
stage/cpu.rs.
• These changes involve updates to the atlas and texture handling, lighting and
shadow mapping improvements, and modifications to the rendering pipeline.
5 GLTF File:
• The gltf/shadow_mapping_sanity_spot.blend file has binary changes, suggesting
updates to the 3D model or scene configuration.
Overall, the changes focus on improving the rendering and lighting systems,
particularly around shadow mapping and texture management.
* feat: Add shadow map view management for directional and point lights
* feat: Implement `ShadowMapViews::new_six` for point light shadow maps
* moved shadow maps to a shadow map atlas, included atlas blitting
* WIP moving all lighting to the lighting slab w/ AnalayticalLightBundle
* functional shadows read out of the shadow map atlas
… intensity from GLTF files
…ight intensity, move ShadowMap into its own cpu module
* WIP * move stage's render of objects to StageRendering to reuse in SceneCubemap * chore: hand rolled cubemap sampling
schell
force-pushed
the
feature/shadow-mapping
branch
from
15eb9f0 to
f5557b5
Compare
* cubemap sampling fixes * fixed hand-rolled cubemap sampling * point light shadows use disk sampling for PCF, added z_far to ShadowMapDescriptor * update shadow map descriptor with light bundle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes provide a shadow mapping implementation for casting shadows from analytical lights.
Includes: