Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Bumped node-gyp version#2638

Closed
meszaros-lajos-gyorgy wants to merge 1 commit intosass:masterfrom
meszaros-lajos-gyorgy:master
Closed

Bumped node-gyp version#2638
meszaros-lajos-gyorgy wants to merge 1 commit intosass:masterfrom
meszaros-lajos-gyorgy:master

Conversation

@meszaros-lajos-gyorgy
Copy link
Copy Markdown

A new version of node-gyp was just released based on this comment: nodejs/node-gyp#1718 (comment)

@meszaros-lajos-gyorgy
Copy link
Copy Markdown
Author

Should fix #2625.

@xzyfer
Copy link
Copy Markdown
Contributor

xzyfer commented Apr 24, 2019

Please check all the other duplicate closed PRs. The fix is much more complicated for us. We're on it.

@xzyfer xzyfer closed this Apr 24, 2019
@mikern12
Copy link
Copy Markdown

I mentioned this on this thread (1456ef2) , but I am still having an issue when I update node-gyp. I run npm install node-gyp and get the correct 4.0.0 package, but then I get an error that I something changed and I need to "Run npm rebuild node-sass to download the binding for your current environment." When I do this, it re-loads the 3.8.x version of node-gyp. Error below from the rebuild of node-sass:

gyp ERR! node -v v9.4.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! This is a bug in node-gyp.
gyp ERR! Try to update node-gyp and file an Issue if it does not help:
gyp ERR! https://github.com/nodejs/node-gyp/issues
Build failed with error code: 7
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! node-sass@4.11.0 postinstall: node scripts/build.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the node-sass@4.11.0 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants