Skip to content

Fix limit to only allow positive value on validation on Finder::rows()#39

Merged
samsonasik merged 1 commit intomainfrom
fix-limit-validation
Feb 15, 2026
Merged

Fix limit to only allow positive value on validation on Finder::rows()#39
samsonasik merged 1 commit intomainfrom
fix-limit-validation

Conversation

@samsonasik
Copy link
Owner

@samsonasik samsonasik commented Feb 15, 2026

$limit 0 must not allowed.

@samsonasik samsonasik changed the title Fix limit positive value validation on Finder::rows() Fix limit to only allow positive value validation on Finder::rows() Feb 15, 2026
@samsonasik samsonasik changed the title Fix limit to only allow positive value validation on Finder::rows() Fix limit to only allow positive value on validation on Finder::rows() Feb 15, 2026
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c45927f) to head (4df276c).
⚠️ Report is 64 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                main       #39    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity        45        81    +36     
============================================
  Files              4         7     +3     
  Lines            122       237   +115     
============================================
+ Hits             122       237   +115     
Flag Coverage Δ
tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samsonasik samsonasik merged commit b1c641c into main Feb 15, 2026
8 checks passed
@samsonasik samsonasik deleted the fix-limit-validation branch February 15, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants