fix: Make Settings page toggle buttons responsive and persistent#9
Open
Sumeet2005 wants to merge 1 commit intosammyifelse:masterfrom
Open
fix: Make Settings page toggle buttons responsive and persistent#9Sumeet2005 wants to merge 1 commit intosammyifelse:masterfrom
Sumeet2005 wants to merge 1 commit intosammyifelse:masterfrom
Conversation
- Add Settings section to Dashboard with Dark Mode and High Contrast toggles - Implement proper state management using React useState hooks - Add localStorage persistence for settings across browser sessions - Add proper onChange event handlers for Material-UI Switch components - Apply theme changes immediately when toggles are clicked - Fix unresponsive toggle button issue mentioned in GitHub issue Toggle buttons now: ✅ Respond to user clicks (were unresponsive) ✅ Save state to localStorage (persist across sessions) ✅ Apply visual changes immediately (dark theme, contrast) ✅ Show current status with visual indicators Closes #[issue-number]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem Fixed
Fixed unresponsive toggle buttons on Settings page as described in the issue. Toggle buttons were not registering clicks and settings were not persisting across page refreshes.
✅ Solution Implemented
Added a complete Settings section to the Dashboard component with fully functional Dark Mode and High Contrast toggle buttons.
📋 Changes Made
Core Functionality
useStatehooks for toggle statesFeatures Added
Technical Implementation
FormControlLabel,Switch,Divider,Settings as SettingsIconisDarkMode,isHighContrastuseEffecthooks for localStorage loading and theme applicationhandleDarkModeToggle,handleHighContrastToggle🔧 Issues Resolved
🧪 Testing
The toggle buttons now:
📱 User Experience
🔗 Closes
Fixes the Settings page toggle button issue - buttons are now fully responsive and persistent.