Gave main.py a more obvious entry point#11
Open
PrestonXPitzer wants to merge 1 commit intorweigel:mainfrom
Open
Gave main.py a more obvious entry point#11PrestonXPitzer wants to merge 1 commit intorweigel:mainfrom
PrestonXPitzer wants to merge 1 commit intorweigel:mainfrom
Conversation
…ame__ == __main__ idiom for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original file, main.py had no main method, making it visually unclear where the entry point to the program was. I wrapped the dangling code in a main() method and added the if name == "main" idiom so IDE's and users can better distinguish which code is meant to be run.
This required a modification to the generate() and compare() functions, because originally the logger object was in the global scope. It is now passed between these functions, but the functionality is unchanged.
Tests pass