FCW Lint when using an ambiguously glob imported trait by LorrensP-2158466 · Pull Request #149058 · rust-lang/rust

LorrensP-2158466 · 2025-11-18T11:54:03Z

Related to #147992.

Report a lint when using an ambiguously glob import trait, this is a FCW because this should not be allowed.

r? @petrochenkov

compiler/rustc_resolve/src/lib.rs

LorrensP-2158466 · 2025-11-19T18:39:56Z

Addressed your comments and updated pr title and description.

@rustbot ready

LorrensP-2158466 · 2025-11-19T18:41:04Z

compiler/rustc_hir_typeck/src/method/confirm.rs

+        self.tcx.node_lint(AMBIGUOUS_TRAIT_GLOB_IMPORTS, segment.hir_id, |diag| {
+            diag.primary_message(format!("Use of ambiguously glob imported trait `{trait_name}`"))
+                .span(segment.ident.span)
+                .span_label(import_span, format!("`{trait_name}`imported ambiguously here"))
+                .help(format!("Import `{trait_name}` explicitly"));
+        });


Is it possible to add some kind of suggestion like:

Consider importing `{trait_name}` directly: + use m1::{trait_name};

tests/ui/imports/ambiguous-trait-in-scope.rs

compiler/rustc_hir/src/hir.rs

compiler/rustc_hir_typeck/src/method/confirm.rs

LorrensP-2158466 · 2025-11-20T13:58:35Z

@rustbot ready

petrochenkov · 2025-11-20T14:05:17Z

r? @lcnr or someone else from types for the method resolution part.

This will need to go through crater and then lang team after the review.

LorrensP-2158466 · 2026-01-18T13:36:17Z

Can't do r=you. @rustbot ready

petrochenkov · 2026-01-18T13:51:09Z

@bors r+

rust-bors · 2026-01-18T13:51:12Z

📌 Commit 27629ec has been approved by petrochenkov

It is now in the queue for this repository.

rust-bors · 2026-01-18T14:49:19Z

⚠️ A new commit 65c70e4579ce3312330cfda2704e21343aadb60f was pushed to the branch, the PR will need to be re-approved.

LorrensP-2158466 · 2026-01-18T14:50:12Z

Damn... sorry, should've grepped lower-case as well. Should be good now
@rustbot ready

petrochenkov · 2026-01-18T15:02:07Z

@bors r+

rust-bors · 2026-01-18T15:02:10Z

📌 Commit 65c70e4 has been approved by petrochenkov

It is now in the queue for this repository.

compiler/rustc_lint_defs/src/builtin.rs

tests/ui/imports/no-ambiguous-trait-lint-on-redundant-import.rs

compiler/rustc_hir_typeck/src/method/confirm.rs

traviscross · 2026-01-18T15:46:08Z

@bors r-

Still some left to fix.

rust-bors · 2026-01-18T15:46:12Z

Commit 65c70e4 has been unapproved.

LorrensP-2158466 · 2026-01-18T16:04:08Z

I did rg "AMBIGUOUS_GLOB_IMPORTED_TRAIT" . -i on the entire rust directory and only found matches with an S at the end. So it should be good, now...

Sorry for being a bit to fast

@rustbot ready

LorrensP-2158466 · 2026-01-18T17:07:33Z

@rustbot author

Note to self: never do OSS when away from home.

…its.

LorrensP-2158466 · 2026-01-20T12:35:32Z

Did the commands locally and everything works. @rustbot ready

petrochenkov · 2026-01-20T12:38:20Z

@bors r+

rust-bors · 2026-01-20T12:38:23Z

📌 Commit 3369a17 has been approved by petrochenkov

It is now in the queue for this repository.

rustbot assigned petrochenkov Nov 18, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 18, 2025

This comment has been minimized.

Sign in to view

petrochenkov mentioned this pull request Nov 18, 2025

resolve: Do not consider traits from ambiguous imports to be in scope #147995

Closed

petrochenkov reviewed Nov 18, 2025

View reviewed changes

compiler/rustc_resolve/src/lib.rs Outdated Show resolved Hide resolved

petrochenkov reviewed Nov 19, 2025

View reviewed changes

compiler/rustc_resolve/src/lib.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2025

LorrensP-2158466 changed the title ~~resolve: Consider all traits ambiguously glob imported to be in scope~~ Lint when using an ambiguously glob imported trait Nov 19, 2025

LorrensP-2158466 changed the title ~~Lint when using an ambiguously glob imported trait~~ FCW Lint when using an ambiguously glob imported trait Nov 19, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 19, 2025

LorrensP-2158466 commented Nov 19, 2025

View reviewed changes

petrochenkov reviewed Nov 20, 2025

View reviewed changes

tests/ui/imports/ambiguous-trait-in-scope.rs Show resolved Hide resolved

compiler/rustc_hir/src/hir.rs Outdated Show resolved Hide resolved

compiler/rustc_hir_typeck/src/method/confirm.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025

This was referenced Nov 20, 2025

resolve: Consider all traits from ambiguous glob imports to be in scope #148946

Closed

resolve: Consider traits from shadowed glob imports to be in scope #148943

Closed

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2025

This comment has been minimized.

Sign in to view

LorrensP-2158466 force-pushed the amb-trait-lint branch 2 times, most recently from 43c4a25 to 27629ec Compare January 18, 2026 13:35

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 18, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026

This comment has been minimized.

Sign in to view

LorrensP-2158466 force-pushed the amb-trait-lint branch from 27629ec to 65c70e4 Compare January 18, 2026 14:49

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 18, 2026

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 18, 2026

traviscross reviewed Jan 18, 2026

View reviewed changes

compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved

tests/ui/imports/no-ambiguous-trait-lint-on-redundant-import.rs Outdated Show resolved Hide resolved

compiler/rustc_hir_typeck/src/method/confirm.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Implements a FCW lint to detect uses of ambiguously glob imported tra…

3369a17

…its.

GuillaumeGomez mentioned this pull request Jan 20, 2026

Rollup of 6 pull requests #151409

Merged

petrochenkov mentioned this pull request Feb 13, 2026

The set of traits in scope behaves unpredictably in presence of ambiguous glob imports #147992

Closed

LorrensP-2158466 mentioned this pull request Feb 18, 2026

Tracking Issue for future-incompatibility lint ambiguous_glob_imported_traits #152822

Open

Uh oh!

Conversation

LorrensP-2158466 commented Nov 18, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

LorrensP-2158466 commented Nov 19, 2025

Uh oh!

LorrensP-2158466 Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LorrensP-2158466 commented Nov 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Nov 20, 2025

Uh oh!

LorrensP-2158466 commented Jan 18, 2026

Uh oh!

petrochenkov commented Jan 18, 2026

Uh oh!

rust-bors bot commented Jan 18, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 18, 2026

Uh oh!

LorrensP-2158466 commented Jan 18, 2026

Uh oh!

petrochenkov commented Jan 18, 2026

Uh oh!

rust-bors bot commented Jan 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

traviscross commented Jan 18, 2026

Uh oh!

rust-bors bot commented Jan 18, 2026

Uh oh!

LorrensP-2158466 commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

LorrensP-2158466 commented Jan 18, 2026

Uh oh!

LorrensP-2158466 commented Jan 20, 2026

Uh oh!

petrochenkov commented Jan 20, 2026

Uh oh!

rust-bors bot commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

LorrensP-2158466 commented Nov 18, 2025 •

edited by rustbot

Loading

LorrensP-2158466 Nov 19, 2025 •

edited

Loading

LorrensP-2158466 commented Jan 18, 2026 •

edited

Loading