Merged
Conversation
`gcc` is already a package installed, but it does not install a `libc` candidate with it. `musl-dev` contains the necessary development files (`crti.o`, `crtn.o`, `Scrt1.o`, `libc.so`, etc.). This was prior requested in #68 and is necessary for `proc-macro`s/build scripts to compile, without additional configuration/setup. It also is apparently just a 2% size increase which many consumers are already incurring due to how only effectively bare-metal compilation is possible without it.
Muscraft
reviewed
Dec 3, 2025
Member
Muscraft
left a comment
Muscraft
left a comment
There was a problem hiding this comment.
I looked into this for a while last night, and I think that this is a good change to make. The improved user experience is well worth the ~2% size increase in my opinion, especially when you consider how many people pull it in themselves.
|
|
||
| RUN apk add --no-cache \ | ||
| ca-certificates \ | ||
| musl-dev \ |
Member
There was a problem hiding this comment.
Can you add this to the Alpine Dockerfiles in both nightly/ and stable/?
You should be able to update all of them at once by running:
./x.py update
Contributor
Author
|
Updated. Apologies for not doing so when I first made the PR, and thanks for telling me how to :) |
Muscraft
approved these changes
Dec 3, 2025
Member
tyranron
added a commit
to instrumentisto/rust-docker-image
that referenced
this pull request
Dec 4, 2025
paolobarbolini
added a commit
to M4SS-Code/range-requests
that referenced
this pull request
Dec 12, 2025
It's already included by default starting from rust-lang/docker-rust#259
paolobarbolini
added a commit
to M4SS-Code/watermelon
that referenced
this pull request
Dec 12, 2025
It's already included by default starting from rust-lang/docker-rust#259
paolobarbolini
added a commit
to M4SS-Code/benzina
that referenced
this pull request
Dec 12, 2025
It's already included by default starting from rust-lang/docker-rust#259
paolobarbolini
added a commit
to M4SS-Code/static-serve
that referenced
this pull request
Dec 12, 2025
It's already included by default starting from rust-lang/docker-rust#259
paolobarbolini
added a commit
to M4SS-Code/cargo-goggles
that referenced
this pull request
Dec 12, 2025
It's already included by default starting from rust-lang/docker-rust#259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gccis already a package installed, but it does not install alibccandidate with it.musl-devcontains the necessary development files (crti.o,crtn.o,Scrt1.o,libc.so, etc.).This was prior requested in #68 and is necessary for
proc-macros/build scripts to compile, without additional configuration/setup. It also is apparently just a 2% size increase which many consumers are already incurring due to how only effectively-bare-metal compilation is possible without it.