Inherit queue type for retry and error queues#38
Merged
michaelklishin merged 1 commit intoruby-amqp:mainfrom Jan 9, 2026
Merged
Inherit queue type for retry and error queues#38michaelklishin merged 1 commit intoruby-amqp:mainfrom
michaelklishin merged 1 commit intoruby-amqp:mainfrom
Conversation
Member
|
@chris72205 thank you, you have proactively addressed my key concern: what to do if the user does not want to use quorum queues for everything (a non-replicated classic queue can be a reasonable choice for the "plumbing" queues). |
michaelklishin
approved these changes
Jan 9, 2026
Member
|
I will update the change log to credit @chris72205 later today. Thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can configure a queue as type
quorumbut this was not reflected in the-errorand-retryqueues provided by theMaxretryhandler. This PR allows setting the queue type based on thex-queue-typeargument set in the queue options:I also added the ability to specify a specific type for each just in case sharing the type of the queue is not desired.