Open
Conversation
Add complete Firo chain integration following the established UTXO chain pattern (Doge/Bitcoin): - networks/firo: Network package with client, constants, types, UTXO selection, transaction generation, and BlockCypher API utilities - wallets/firo-wallet: Wallet package with browser extension integration (connect, sign, broadcast) - apps/rosen: App wiring with server actions, lock address config, and wallet registration - packages/constants: Add Firo to NETWORKS (index 7, native token: firo) - packages/icons: Add Firo network SVG icon - packages/utils: Add Firo explorer URLs (address, token, tx) - apps/rosen-service: Gracefully skip unconfigured chains in commitment extractor registration Co-authored-by: Reuben Yap <reuben@firo.org>
- Add networks/firo and wallets/firo-wallet to build.sh (BEK requirement) - Clean up firo.svg: remove XML declaration and unnecessary attributes, keep only viewBox and xmlns (consistent with other network SVGs) - Fix typo: opRetrunDataLength -> opReturnDataLength in getMaxTransfer.ts - Fix incorrect JSDoc @param references in utils.ts Co-authored-by: Reuben Yap <reuben@firo.org>
|
@cursoragent is attempting to deploy a commit to the rosen-bridge Team on Vercel. A member of the Team first needs to authorize it. |
Closed
abdolian
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds complete Firo chain integration to the Rosen Bridge UI, following the established UTXO chain pattern used by Doge and Bitcoin.
Commits
The PR is structured as two commits for easy review:
feat: add Firo network support— The full Firo integration (equivalent to the changes in add firo support #15)fix: address review feedback on Firo integration— Fixes for the issues identified in the add firo support #15 reviewChanges
Firo Integration (commit 1)
networks/firo/: Network package with client class, constants, types, UTXO selection, transaction generation, and BlockCypher API utilitieswallets/firo-wallet/: Wallet package with browser extension integration (connect, sign, broadcast)apps/rosen/: App wiring with server actions, lock address config, and wallet registrationpackages/constants: Add Firo toNETWORKS(index 7, native token:firo)packages/icons: Add Firo network SVG iconpackages/utils: Add Firo explorer URLs (address, token, tx)apps/rosen-service: Gracefully skip unconfigured chains in commitment extractor registrationapps/rosen/.env.example: AddFIRO_BLOCKCYPHER_APIvariableReview Fixes (commit 2)
Addresses the feedback from #15:
build.sh: Addnetworks/firoandwallets/firo-walletworkspaces to the build script (per BEK documentation requirement, as noted by @abdolian)firo.svg: Remove XML declaration and unnecessary attributes; keep onlyviewBoxandxmlnsconsistent with other network SVGs (as noted by @abdolian)getMaxTransfer.ts: Fix typoopRetrunDataLength→opReturnDataLengthutils.ts: Fix incorrect JSDoc@paramreferences