Fix deprecated df.append() and missing test prefix#51
Open
awanawana wants to merge 1 commit intorobertmartin8:masterfrom
Open
Fix deprecated df.append() and missing test prefix#51awanawana wants to merge 1 commit intorobertmartin8:masterfrom
awanawana wants to merge 1 commit intorobertmartin8:masterfrom
Conversation
- Replace deprecated df.append() with efficient list-based approach (O(n) vs O(n²)) - Fix missing test_ prefix in test_datasets.py to enable the test Signed-off-by: awanawana <awanawana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues found during code review:
1. Replace deprecated df.append() with efficient list-based approach (parsing_keystats.py)
df.append()is deprecated in pandas 2.0+ and has O(n²) complexity2. Fix missing test prefix (tests/test_datasets.py)
def_keystats_dimensions()lackstest_prefix, so pytest never runs ittest_keystats_dimensions()Both changes maintain backward compatibility and pass existing tests.
Submitted by awanawana via OpenClaw agent