Fix JsonPolymorphic attribute with DisableDotvvmConverter=true#2007
Open
Fix JsonPolymorphic attribute with DisableDotvvmConverter=true#2007
Conversation
Main fix is that we need to use `type: dynamic` in metadata, because System.Text.Json does not tolerate any properties starting with `$` during deserialization. Apart from that I added error during initialization if you use JsonPolymorphic and did not set DisableDotvvmConverter, since it's most likely unintended. We also want to add support for this later, and if make it a hard error now, it won't be a breaking change to add some support.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+231
to
+237
| if (!disableDotvvmConverter) | ||
| { | ||
| if (type.IsDefined(typeof(JsonPolymorphicAttribute))) | ||
| throw new NotSupportedException( | ||
| $"Can not serialize {type.ToCode()} as [JsonPolymorphic] attribute is currently not supported by DotVVM. " + | ||
| "You can use [DotvvmSerialization(DisableDotvvmConverter = true)] to fall back to System.Text.Json default behavior, please note the client-side bindings to such models may not work properly."); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main fix is that we need to use
type: dynamicin metadata, because System.Text.Json does not tolerate any properties starting with$during deserialization.Apart from that I added error during initialization if you use JsonPolymorphic and did not set DisableDotvvmConverter, since it's most likely unintended.
We also want to add support for this later, and if make it a hard error now, it won't be a breaking change to add some support.