Conversation
There was a problem hiding this comment.
Pull request overview
This pull request re-introduces JSON diffing functionality for postback responses to reduce payload sizes. Instead of sending the complete viewModel in postback responses, the server now computes a diff between the viewModel it received from the client and the updated viewModel, then sends only the changes.
Changes:
- Added
JsonDiffWriter- a high-performance UTF-8-based JSON diff computation utility that uses ref structs and stack allocation - Modified
DefaultViewModelSerializerto compute and send viewModelDiff instead of full viewModel when diff source is available - Added comprehensive test coverage with 40+ test cases validating the diff algorithm against the existing
JsonUtils.Diffimplementation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
JsonDiffWriter.cs |
New ref struct implementing high-performance JSON diff computation using UTF-8 reader/writer with lazy evaluation for nested objects |
JsonPatchWriter.cs |
Entirely commented-out code for applying patches (should be removed or moved) |
DefaultViewModelSerializer.cs |
Integrated diff computation into serialization flow, added error handling, refactored to support diff mode |
JsonDiffTests.cs |
Added 40+ test cases validating diff algorithm correctness, removed BOM, added debug console output |
DotVVM.Framework.csproj |
Changed target framework order to prioritize net9.0 |
dotnet-tools.json |
Added dotnet-stryker mutation testing tool (unrelated to PR) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Framework/Framework/ViewModel/Serialization/DefaultViewModelSerializer.cs
Show resolved
Hide resolved
src/Framework/Framework/ViewModel/Serialization/DefaultViewModelSerializer.cs
Show resolved
Hide resolved
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+128
to
+133
| catch (Exception ex) | ||
| { | ||
| writer.Flush(); | ||
| var failurePath = SystemTextJsonUtils.GetFailurePath(writerStream.ToSpan()); | ||
| throw new SerializationException(true, context.ViewModel!.GetType(), string.Join("/", failurePath), ex); | ||
| } |
tomasherceg
approved these changes
Feb 15, 2026
Comment on lines
+323
to
+325
| { | ||
|
|
||
| } |
Comment on lines
+322
to
+325
| if (addedToBuffer) | ||
| { | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.