Skip to content

Browserstack observability reload session fix #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rev-doshi wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Browserstack observability reload session fix #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
269bd4e
sending current session id to test observability
rev-doshi Feb 15, 2024
782cdcb
Merge branch 'main' of github.com:rev-doshi/webdriverio into SDK-416-…
rev-doshi Feb 21, 2024
198a35e
minor fix
rev-doshi Feb 21, 2024
d80d142
Merge branch 'main' of github.com:rev-doshi/webdriverio into browsers…
rev-doshi Feb 23, 2024
262e039
unit tests
rev-doshi Feb 27, 2024
f8a73f4
Merge branch 'main' into browserstack-observability-reload-session-fix
rev-doshi Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/wdio-browserstack-service/src/insights-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,12 +864,15 @@ class _InsightsHandler {
}

private getIntegrationsObject () {
const caps = (this._browser as WebdriverIO.Browser)?.capabilities as WebdriverIO.Capabilities
const sessionId = (this._browser as WebdriverIO.Browser)?.sessionId

return {
capabilities: this._platformMeta?.caps,
session_id: this._platformMeta?.sessionId,
browser: this._platformMeta?.browserName,
browser_version: this._platformMeta?.browserVersion,
platform: this._platformMeta?.platformName,
capabilities: caps,
session_id: sessionId,
browser: caps?.browserName,
browser_version: caps?.browserVersion,
platform: caps?.platformName,
product: this._platformMeta?.product,
platform_version: getPlatformVersion(this._userCaps as WebdriverIO.Capabilities)
}
Expand Down
12 changes: 12 additions & 0 deletions packages/wdio-browserstack-service/tests/insights-handler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,18 @@ describe('getIntegrationsObject', () => {
expect(integrationsObject.platform_version).toEqual('some version')
})

it('should fetch latest details', () => {
const existingSessionId = browser.sessionId
const existingOs = browser.capabilities.os
browser.sessionId = 'session-new'
browser.capabilities.os = 'Windows'
const integrationsObject = insightsHandler['getIntegrationsObject']()
expect(integrationsObject.session_id).toEqual('session-new')
expect(integrationsObject.capabilities.os).toEqual('Windows')
browser.sessionId = existingSessionId
browser.capabilities.os = existingOs
})

afterAll(() => {
getPlatformVersionSpy.mockReset()
})
Expand Down