Add native TopologyBuilder parity, validations, and tests#69
Merged
Conversation
reembs
force-pushed
the
native-builder
branch
from
c645601 to
ba75910
Compare
- Implement KumulusTopologyBuilder public API parity with Storm TopologyBuilder, including additional setBolt overloads, setStateSpout/addWorkerHook stubs, and IBasicBolt compatibility. - Align native builder validations with Storm behavior (duplicate component IDs, positive parallelism, null worker hook handling). - Fix native builder config serialization/merging to mirror Storm declarers, including topology.kryo.register rejection and JSON conf merge semantics. - Add reflection-based API parity and configuration parity tests for the native builder. - Add duplicate-ID/validation tests and migrate existing tests (except KumulusStormTransformerTest) from Storm TopologyBuilder to KumulusTopologyBuilder.
reembs
force-pushed
the
native-builder
branch
from
ba75910 to
03de4ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement KumulusTopologyBuilder public API parity with Storm TopologyBuilder, including additional setBolt overloads, setStateSpout/addWorkerHook stubs, and IBasicBolt compatibility.
Align native builder validations with Storm behavior (duplicate component IDs, positive parallelism, null worker hook handling).
Fix native builder config serialization/merging to mirror Storm declarers, including topology.kryo.register rejection and JSON conf merge semantics.
Add reflection-based API parity and configuration parity tests for the native builder.
Add duplicate-ID/validation tests and migrate existing tests (except KumulusStormTransformerTest) from Storm TopologyBuilder to KumulusTopologyBuilder.