Fix CSP 'unsafe-eval' error preventing Remote DevTools connection#1934
Open
sangmokh wants to merge 3 commits intoreduxjs:mainfrom
Open
Fix CSP 'unsafe-eval' error preventing Remote DevTools connection#1934sangmokh wants to merge 3 commits intoreduxjs:mainfrom
sangmokh wants to merge 3 commits intoreduxjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6e7e0bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b8ebaf2 to
7b0285b
Compare
|
Can this be merged soon? |
|
Waiting for this as well |
|
Wanted to chime in as I'm also running on a manually patched version and waiting for this to land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#1783
Analysis
The
unsafe-evalCSP error occurs inForm.tsxwhen@rjsf/validator-ajv8attempts to useeval()for JSON schema validation. This happens because the library falls back to runtime compilation when precompiled validators are not available.Solution / Workaround
Addressing the root cause by migrating to precompiled validators would require significant refactoring, as
Form.tsxis used with multiple schema configurations across multiple components. Yet the Remote Redux DevTool feature is unsuable without fixing the form error.Two simple workarounds were considered:
unsafe-evalThis PR opted for the first approach because the UI already constrains the
portfield to numeric values and thesecurefield to boolean values, making theeval-based ajv validation redundant. The second approach was avoided as it would compromise the security of the Remote DevTools window.