[Fix] react-json-tree: Handle sparse empty arrays greater than limit#1828
Open
arcataroger wants to merge 2 commits intoreduxjs:mainfrom
Open
[Fix] react-json-tree: Handle sparse empty arrays greater than limit#1828arcataroger wants to merge 2 commits intoreduxjs:mainfrom
arcataroger wants to merge 2 commits intoreduxjs:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially fixes #1827
Given an input like:
Currently
getCollectionEntries()and itsisRange()call does not properly handle sparse arrays greater than thelimit. It will try to pass through empty entries to theisRange()and subsequentconst { key, value } = entrydestructuring, both of which halt the script.This PR bypasses the crash and allows the rendering to continue.
There is a separate cosmetic bug that this PR does NOT fix:
limitedEntriesin getCollectionEntries() is not subset, butlimit - 4===length - 5, it will cause a single-item collapsed range