Add some accessibility to the react-json-tree for keyboard naviagation, also allow Arrow Override#1747
Open
tisdadd wants to merge 4 commits intoreduxjs:mainfrom
Open
Add some accessibility to the react-json-tree for keyboard naviagation, also allow Arrow Override#1747tisdadd wants to merge 4 commits intoreduxjs:mainfrom
tisdadd wants to merge 4 commits intoreduxjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: bfa9c3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library had met everything I needed but for the fact that I wanted things to be able to be navigated by keyboards. Default arrows are now focusable as buttons and have some basic aria expandable applied. Looked into treeitem roles but realized that they are explicitly set for a selectable tree inputs, so treated it as standard expandable list.
I saw Issue 464 when I was initially looking simply into replacing with buttons, and realized that I should probably still throw that in there.
Hopefully this is helpful, if not or if I should do something else, please let me know.