Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/deploy/partials/linux/install-fips.adoc (1)
30-31: Ensure consistent yum flag placement and tighten script invocation
The current command is:curl -1sLf 'https://dl.redpanda.com/nzc4ZYQK3WRGd9sy/redpanda/cfg/setup/bash.rpm.sh' | \ sudo -E bash && sudo yum install redpanda -yRecommendations:
- Move the
-yflag directly afterinstallfor consistency and readability:- sudo yum install redpanda -y + sudo yum install -y redpanda- Consider dropping
-Eon thesudo bashinvocation to avoid unintentionally preserving user environment variables in a FIPS-sensitive context.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/deploy/partials/linux/install-fips.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (1)
modules/deploy/partials/linux/install-fips.adoc (1)
34-34: Alternative install note is clear and correct
The note:NOTE: Alternatively, you could run `sudo yum install -y redpanda-fips`, which also picks up and includes the `redpanda` install package.is accurate and follows the non-interactive install pattern. No changes required.
WalkthroughThe installation instructions for Redpanda on RHEL-based Linux systems were updated. The previous use of Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/deploy/partials/linux/install-fips.adoc (1)
34-34: Nitpick: streamline the note for conciseness
Consider rephrasing to remove unnecessary words and clarify thatredpandais installed as a dependency:- NOTE: Alternatively, you could run `sudo yum install -y redpanda-fips`, which also picks up and includes the `redpanda` install package. + NOTE: Alternatively, run `sudo yum install -y redpanda-fips`, which also installs the `redpanda` package as a dependency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/deploy/partials/linux/install-fips.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (1)
modules/deploy/partials/linux/install-fips.adoc (1)
30-31: Correct use of RHEL installation command
The updated instructions now properly use the Redpanda RPM setup script followed byyum installto enable FIPS mode on RHEL systems. This aligns with RHEL’s package management.
This pull request updates the installation instructions for Redpanda with FIPS compliance on Linux. The changes replace the use of
aptwithyumfor package installation and update the corresponding commands and notes.Changes to installation instructions:
modules/deploy/partials/linux/install-fips.adoc: Updated the installation command to usecurlandyumfor setting up Redpanda with FIPS compliance, replacing the previousapt-based instructions. The alternative installation note was also updated to reflect the use ofyum.## DescriptionResolves https://redpandadata.atlassian.net/browse/DOC-748
Review deadline: Tuesday April 22
Page previews
Install Redpanda for FIPS compliance
Checks
Summary by CodeRabbit
yuminstead ofapt, providing clearer steps for Redpanda installation on RPM-based distributions. Debian/Ubuntu instructions remain unchanged.