(sending messages) fix routes files in the app.py#157
Open
SaarCohen93 wants to merge 8 commits intoredhat-beyond:masterfrom
Open
(sending messages) fix routes files in the app.py#157SaarCohen93 wants to merge 8 commits intoredhat-beyond:masterfrom
SaarCohen93 wants to merge 8 commits intoredhat-beyond:masterfrom
Conversation
Contributor
Author
|
@lioramilbaum |
lmilbaum
suggested changes
Jan 19, 2020
Contributor
lmilbaum
left a comment
lmilbaum
left a comment
There was a problem hiding this comment.
Missing 'fix...' comment and there are still conflicts to resolve
Contributor
Author
|
I fixed all the conflicts, seems now everything is ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so after refactoring we need to add the changes to the home.html.
in addition I fixed the read me problem from the last PR.
Mor ask me to add back the layout.html