Extend and make optional built-in property editing form support#144
Merged
Extend and make optional built-in property editing form support#144
Conversation
AlexeyMz
changed the title
AlexeyMz
force-pushed
the
extract-forms
branch
3 times, most recently
from
0ab76bb to
1c9c25e
Compare
* Extract property editor inputs into separate entry point `@reactodia/workspace/forms` to be able to use external forms implementation without always bundling the built-in one; * Provide `InputText`, `InputList` and `InputSelect` basic form inputs; * Provide `InputFile` form input with `MemoryFileUploader` implementation for `FileUploadProvider` interface; * **[💥Breaking]** `VisualAuthoring` now requires `propertyEditor` prop: the built-in `DefaultPropertyEditor` in combination with imported inputs provides default (built-in) property editing experience; * Expose `useProvidedEntities()` utility hook to have a simple way to load non-canvas entities with cache from a `DataProvider`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@reactodia/workspace/formsto be able to use external forms implementation without always bundling the built-in one;InputText,InputListandInputSelectbasic form inputs;InputFileform input withMemoryFileUploaderimplementation forFileUploadProviderinterface;VisualAuthoringnow requirespropertyEditorprop: the built-inDefaultPropertyEditorin combination with imported inputs provides default (built-in) property editing experience;useProvidedEntities()utility hook to have a simple way to load non-canvas entities with cache from aDataProvider.