fix: preserve default menu icon colors on iOS new arch#1195
Open
michaelpomogajko wants to merge 1 commit intoreact-native-menu:masterfrom
Open
fix: preserve default menu icon colors on iOS new arch#1195michaelpomogajko wants to merge 1 commit intoreact-native-menu:masterfrom
michaelpomogajko wants to merge 1 commit intoreact-native-menu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imageColorandtitleColorfrom the New Architecture bridge when they were not explicitly set in JSRoot cause
In the Fabric/New Architecture path, codegen turns optional
imageColorandtitleColorfields into plain integer props with a default value of0.MenuView.mmalways forwarded those values into the Objective-C action dictionaries, so iOS treated missingimageColoras a real color and tinted SF Symbols to an invisible color.This shows up as menu titles rendering correctly while icons disappear entirely on iOS New Architecture, even when the JS action config follows the documented API.
Validation
@react-native-menu/menu2.0.0ios/NewArch/MenuView.mmonly