Conversation
There was a problem hiding this comment.
Pull request overview
This pull request enhances oRPC error handling by adding new standardized error types (CONFLICT, INTERNAL_SERVER_ERROR, NOT_FOUND) to the oRPC contract root base, and updates the test validation handler to use these new error types. The changes also refactor the API error handling approach by removing throwOnError: true from the external API call and implementing explicit error checking instead.
Changes:
- Added three new error types (CONFLICT, INTERNAL_SERVER_ERROR, NOT_FOUND) to the oRPC contract builder
- Modified the test validate handler to use the errors parameter and throw INTERNAL_SERVER_ERROR when API data is undefined
- Refactored API error handling to remove throwOnError flag in favor of explicit undefined checks
- Updated localization file line references to reflect code reorganization
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/src/common/orpc/vars/bases/root/main.ts | Added three new error type definitions (CONFLICT, INTERNAL_SERVER_ERROR, NOT_FOUND) to the oRPC contract |
| src/src/server/orpc/vars/procedures/vars/test/vars/validate/main.ts | Added errors parameter to handler, removed throwOnError flag, implemented explicit error handling for undefined API responses, and reformatted headers object inline |
| src/src/common/localization/locales/pl.po.jinja | Updated line reference from 28 to 27 due to code restructuring |
| src/src/common/localization/locales/en.po.jinja | Updated line reference from 28 to 27 due to code restructuring |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.