Skip to content

Comments

Improved oRPC errors#36

Merged
spietras merged 1 commit intomainfrom
orpc
Feb 10, 2026
Merged

Improved oRPC errors#36
spietras merged 1 commit intomainfrom
orpc

Conversation

@spietras
Copy link
Member

No description provided.

@spietras spietras requested a review from Copilot February 10, 2026 19:10
@spietras spietras self-assigned this Feb 10, 2026
@spietras spietras added the cleanup Stay fresh label Feb 10, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances oRPC error handling by adding new standardized error types (CONFLICT, INTERNAL_SERVER_ERROR, NOT_FOUND) to the oRPC contract root base, and updates the test validation handler to use these new error types. The changes also refactor the API error handling approach by removing throwOnError: true from the external API call and implementing explicit error checking instead.

Changes:

  • Added three new error types (CONFLICT, INTERNAL_SERVER_ERROR, NOT_FOUND) to the oRPC contract builder
  • Modified the test validate handler to use the errors parameter and throw INTERNAL_SERVER_ERROR when API data is undefined
  • Refactored API error handling to remove throwOnError flag in favor of explicit undefined checks
  • Updated localization file line references to reflect code reorganization

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/src/common/orpc/vars/bases/root/main.ts Added three new error type definitions (CONFLICT, INTERNAL_SERVER_ERROR, NOT_FOUND) to the oRPC contract
src/src/server/orpc/vars/procedures/vars/test/vars/validate/main.ts Added errors parameter to handler, removed throwOnError flag, implemented explicit error handling for undefined API responses, and reformatted headers object inline
src/src/common/localization/locales/pl.po.jinja Updated line reference from 28 to 27 due to code restructuring
src/src/common/localization/locales/en.po.jinja Updated line reference from 28 to 27 due to code restructuring

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@spietras spietras merged commit 9e4cb17 into main Feb 10, 2026
8 checks passed
@spietras spietras deleted the orpc branch February 10, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Stay fresh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant