Remove players from multiplayer room on leave if they have no stats or buzzes#454
Merged
geoffrey-wu merged 2 commits intomainfrom Mar 8, 2026
Merged
Remove players from multiplayer room on leave if they have no stats or buzzes#454geoffrey-wu merged 2 commits intomainfrom
geoffrey-wu merged 2 commits intomainfrom
Conversation
… and no buzzes Co-authored-by: geoffrey-wu <42471355+geoffrey-wu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove players from multiplayer room on leave if no stats or buzzes
Remove players from multiplayer room on leave if they have no stats or buzzes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players who join and immediately leave (never buzzing or hearing a completed tossup) were kept as offline "ghost" entries in the room's player list. These should be fully removed rather than retained as offline.
Changes
Player.js: Addbuzzesfield (reset inclearStats()) andhasActivity()method — returnstrueif any oftuh,buzzes,powers,tens,zeroes, ornegsare non-zeroTossupRoom.js: Incrementplayer.buzzeson each buzzRoom.js:leave()now branches onplayer.hasActivity():playersandteams, emit{ type: 'leave', remove: true }MultiplayerTossupBonusClient.js: Clientleave()handler removes the DOM element and player state whenremove: true; otherwise falls through to existing offline stylingOn reconnect after removal, the player is treated as
isNewand gets a fresh entry — no special handling needed.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.