Correctly sort players by points when joining a new room

[Copilot]

When a player reconnected to a room (isNew=false), the join handler only updated CSS classes and username text manually — skipping upsertPlayerItem and sortPlayerListGroup. This left the list unsorted and the player item stale for all connected clients.

Changes

• client/play/mp/MultiplayerTossupBonusClient.js: Collapsed the isNew branch in the join handler — both new and reconnecting players now go through upsertPlayerItem + sortPlayerListGroup. The server sets user.online = true before broadcasting join, so upsertPlayerItem renders the correct online state without special-casing.

// Before
if (isNew) {
  user.celerity = user.celerity.correct.average;
  upsertPlayerItem(user, { ... });
  this.sortPlayerListGroup();
} else {
  document.getElementById(`list-group-${userId}`).classList.remove('offline');
  document.getElementById('points-' + userId).classList.add('bg-success');
  document.getElementById('points-' + userId).classList.remove('bg-secondary');
  document.getElementById('username-' + userId).textContent = username;
}

// After
user.celerity = user.celerity.correct.average;
upsertPlayerItem(user, { ... });
this.sortPlayerListGroup();

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• qbreader2.z35tynb.mongodb.net
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/website/website/node_modules/.bin/mocha (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Correctly sort players by points when joining a new room</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Correctly sort players by points when joining a new room #415

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.