Refactor autoaugment: extract _AutoAugmentBase to deduplicate fill logic#9447
Open
sunnycho100 wants to merge 2 commits intopytorch:mainfrom
Open
Refactor autoaugment: extract _AutoAugmentBase to deduplicate fill logic#9447sunnycho100 wants to merge 2 commits intopytorch:mainfrom
sunnycho100 wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9447
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 2dcef64 with merge base b358d66 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@sunnycho100 Thanks a lot for opening this PR and for your willingness to contribute to TorchVision! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9446
Motivation
There is a FIXME at line 103 of torchvision/transforms/autoaugment.py asking to eliminate copy-pasted fill standardization code. Four classes (AutoAugment, RandAugment, TrivialAugmentWide, AugMix) all duplicate the same fill-processing block in their forward() methods and independently set interpolation/fill in their init. The v2 version already solved this with _AutoAugmentBase - this brings the same pattern to v1.
Changes
Not changed
Backward-compatible: yes, no public API surface is affected.