Remove dependency on distutils.version#398
Open
ferdnyc wants to merge 1 commit intopythonprofilers:masterfrom
Open
Remove dependency on distutils.version#398ferdnyc wants to merge 1 commit intopythonprofilers:masterfrom
ferdnyc wants to merge 1 commit intopythonprofilers:masterfrom
Conversation
distutils has been removed as of Python 3.12. The replacement for distutils.version.LooseVersion, packaging.version.LegacyVersion, was similarly dropped from packaging as of version 22. The only uses of LooseVersion() checks were to provide compatibility with IPython 0.10 - 0.12. Those versions didn't even support Python 3. Dropping compatibility with ancient IPython is the simplest fix.
|
Looks good, this closes #407 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distutilshas been removed as of Python 3.12.The replacement for
distutils.version.LooseVersion,packaging.version.LegacyVersion, was similarly dropped frompackagingas of version 22.The only uses of
LooseVersion()checks were to provide compatibility with IPython 0.10 - 0.12. Those versions didn't even support Python 3. Dropping compatibility with ancient IPython is the simplest fix.Fixes #407