Conversation
Fixes and removes from pyproject.toml ignore list: - UP008: super() style (9 violations, auto-fixed) - UP045/UP007: Optional[X] type hints (16 violations, auto-fixed + dead code removed) - UP036: outdated sys.version_info check in tests (1 violation) - B011: assert False → raise AssertionError (4 violations) - B018: useless property accesses replaced with explicit method calls (6 violations) - B026: star-arg after keyword in Principal() call (1 violation) - B028: missing stacklevel= in warnings.warn() (1 violation) - B904: raise-from in except clauses (2 violations) - E721: == for type comparisons → is (5 violations) - E731: lambda assignments → def (4 violations) - B007, UP007: were already clean Also removed dead code: TimeStamp type alias was silently undefined in calendarobjectresource.py, collection.py and davobject.py (try/except block was failing because `date` was never imported). Remaining ignore list annotated with violation counts and links to #634 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deal with some of the findings from ruff