WIP: Add Runner callbacks and option to cancel points#385
Open
basnijholt wants to merge 4 commits intomainfrom
Open
WIP: Add Runner callbacks and option to cancel points#385basnijholt wants to merge 4 commits intomainfrom
basnijholt wants to merge 4 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 77.88% 77.73% -0.15%
==========================================
Files 37 37
Lines 5508 5525 +17
Branches 989 995 +6
==========================================
+ Hits 4290 4295 +5
- Misses 1066 1078 +12
Partials 152 152
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2fc9f85 to
1305bcd
Compare
1305bcd to
a1821f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cc @tlaeven
This allows to add periodic callbacks to the
Runnerand adds a way to cancel points that are currently being calculated.Checklist
pre-commit run --all(first install usingpip install pre-commit)pytestpassedType of change
Check relevant option(s).