Skip to content

Added tests for snapshot() behaviour with global keyword#1320

Merged
david-yz-liu merged 8 commits intopyta-uoft:masterfrom
shirleyyzhang:global-behaviour
Apr 2, 2026
Merged

Added tests for snapshot() behaviour with global keyword#1320
david-yz-liu merged 8 commits intopyta-uoft:masterfrom
shirleyyzhang:global-behaviour

Conversation

@shirleyyzhang
Copy link
Copy Markdown
Contributor

@shirleyyzhang shirleyyzhang commented Mar 25, 2026

Proposed Changes

  • This PR increases test coverage for the snapshot() function for usages of the global keyword.
  • The added tests check that current the behavior is correct for reading, assigning, shadowing and nested scope cases
Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Mar 30, 2026

Pull Request Test Coverage Report for Build 23832164429

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.987%

Totals Coverage Status
Change from base Build 23057700087: 0.0%
Covered Lines: 3478
Relevant Lines: 3865

💛 - Coveralls

)
buf.seek(0)
return json.loads(buf.read())
raw = buf.getvalue()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes in this file

Copy link
Copy Markdown
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @shirleyyzhang!

@david-yz-liu david-yz-liu merged commit 9f7dc43 into pyta-uoft:master Apr 2, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants