Convert unit buffer sit sot to untraced sit sot#2005
Open
ricardoV94 wants to merge 3 commits intopymc-devs:v3from
Open
Convert unit buffer sit sot to untraced sit sot#2005ricardoV94 wants to merge 3 commits intopymc-devs:v3from
ricardoV94 wants to merge 3 commits intopymc-devs:v3from
Conversation
10 tasks
ricardoV94
force-pushed
the
untraced_sit_sot
branch
from
70e935c to
4e09961
Compare
Reduces read and write overhead
ricardoV94
force-pushed
the
untraced_sit_sot
branch
from
4e09961 to
5b6b1ce
Compare
Also make local_useless_inc_subtensor a bit more powerful. It's not really useless because it may still need to broadcast or reverse arrays
ricardoV94
force-pushed
the
untraced_sit_sot
branch
from
5b6b1ce to
88c2f53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scan implementations won't bother with reading/writing in the outer loop.
Also tweaked #2003 to always try to inplace untraced_sit_sot in the inner scan function. If not allowed by the Scan destroy_map (meaning the outer input is protected), we do a copy once at the start, and then let it run free.
Also extended rewrite for slice canonicalization to all subtensor-related Ops, which allows simplifying more easily some useless cases like x[:b].set(y), when x is size b (as scan_save_mem can easily do)
Motivated by ongoing work on pymc-devs/pymc#7380