Open
Conversation
…nt (fixes pymc-devs#1332) Removed silent None assignment and replaced with explicit TypeError as discussed in pymc-devs#1332
Added a new function 'correlate1d' to perform correlation on one-dimensional arrays.
Author
|
Fixes #1321 Changes
Type of change
|
Author
|
@pre-commit-ci autofix |
Member
|
Do you have a use-case in mind for correlate? I'm inclined to not merge this because of how light the wrapper is. If you need it in a model you can just do |
Member
|
I think it's just API compat, but it should be called Or from scipy correlate and correlate2d (they don't seem ho have correlate1d) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Type of change