Add user callback for progress info and improve adaptation options#295
Merged
aseyboldt merged 2 commits intopymc-devs:mainfrom Mar 30, 2026
Merged
Add user callback for progress info and improve adaptation options#295aseyboldt merged 2 commits intopymc-devs:mainfrom
aseyboldt merged 2 commits intopymc-devs:mainfrom
Conversation
aseyboldt
force-pushed
the
user-callback
branch
from
40a0bb4 to
adfc81a
Compare
ricardoV94
reviewed
Mar 25, 2026
python/nutpie/sample.py
Outdated
| warnings.warn( | ||
| f"`{_old_name}` is deprecated. " | ||
| f"Use `adaptation='{_new_adaptation}'` instead.", | ||
| DeprecationWarning, |
Member
There was a problem hiding this comment.
Nobody ever sees DeprecationWarning, definitely not users
Suggested change
| DeprecationWarning, | |
| FutureWarning, |
ricardoV94
approved these changes
Mar 25, 2026
Member
ricardoV94
left a comment
ricardoV94
left a comment
There was a problem hiding this comment.
LGTM, suggest using FutureWarning instead of DeprecationWarning
Member
|
Deprecation tests causing a straightforward failure: Caused by: |
aseyboldt
force-pushed
the
user-callback
branch
from
adfc81a to
3395267
Compare
Member
|
still expecting some deprecation warnings in the tests |
aseyboldt
force-pushed
the
user-callback
branch
from
3395267 to
3b20562
Compare
aseyboldt
force-pushed
the
user-callback
branch
from
3b20562 to
2f4a9e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.