Harmonize encoding from h5netcdf with netcdf4#11067
Draft
hmaarrfk wants to merge 8 commits intopydata:mainfrom
Draft
Harmonize encoding from h5netcdf with netcdf4#11067hmaarrfk wants to merge 8 commits intopydata:mainfrom
hmaarrfk wants to merge 8 commits intopydata:mainfrom
Conversation
4 tasks
hmaarrfk
force-pushed
the
harmonize_h5netcdf_with_netcdf4
branch
from
56c6396 to
71aa924
Compare
hmaarrfk
commented
Jan 3, 2026
Comment on lines
270
to
275
| "zlib", | ||
| "szip", | ||
| "bzip2", | ||
| "blosc", | ||
| "zstd", |
Contributor
Author
There was a problem hiding this comment.
todo: learn why this is a different bug?
hmaarrfk
commented
Jan 3, 2026
hmaarrfk
force-pushed
the
harmonize_h5netcdf_with_netcdf4
branch
from
bea7ba4 to
255d849
Compare
Contributor
Author
|
closing since being more aggressive seems to be ok |
hmaarrfk
force-pushed
the
harmonize_h5netcdf_with_netcdf4
branch
from
c0d66e3 to
2006346
Compare
We were trying to figure why certain compression features were not included in our h5netcdf backend. This PR to h5netcdf should provide the filters variable, but I understand that it is too bleeding edge for you all to pin to h5netcdf/h5netcdf#307
hmaarrfk
force-pushed
the
harmonize_h5netcdf_with_netcdf4
branch
from
0526993 to
25b1b0d
Compare
kmuehlbauer
reviewed
Jan 19, 2026
Contributor
kmuehlbauer
left a comment
kmuehlbauer
left a comment
There was a problem hiding this comment.
@hmaarrfk typo? It's h5netcdf 1.8.0
Contributor
Author
yes thanks, i kinda just played off memory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were trying to figure why certain compression features were not included in our h5netcdf backend.
This PR to h5netcdf should provide the filters variable, but I understand that it is too bleeding edge for you all to pin to h5netcdf/h5netcdf#307
xref: #10657
Ultimately, I don't think you can change the backend without ensuring it is "drop in replacement" at least in what concerns metadata.
Critically, if you compress certain data with zstd, and you try to resave it, it would be saved as 'raw' ruining any gains you had from the compression.
whats-new.rstapi.rst