fix: Include index coordinates in to_dataframe when name differs from dimension (Fixes #10851)#11025
fix: Include index coordinates in to_dataframe when name differs from dimension (Fixes #10851)#11025samay2504 wants to merge 2 commits intopydata:mainfrom
Conversation
578d388 to
98fafb2
Compare
for more information, see https://pre-commit.ci
|
to confirm: same feedback on this as the others |
|
@samay2504 out of curiosity did you use a coding agent for this PR? The test in a standalone file like that feel like a very common claude tic. Independent of the answer, we may want to have a policy about acknowledging how if at all AI was used in a PR, and potentially add lines to AGENTS.md about more reasonable places for tests. |
|
@ianhi actually i was asked to create a standalone file for test for this specific issue ,in my other PR ,other wise initially I added it as modified conftest amongst other already existing test. |
|
Got it! Thanks for the explanation. A hopefully helpful tip is to pre-emptively include explanations in the PR description. Becuase not everyone who sees this PR (i.e. me) will have the full context from other PRs. So the description should hopefully get a new reader up to speed on the design choices and tradeoffs. |
|
tbc, totally fine to use agents @samay2504 , we want improvements! please offer transparency so reviewers can review with the appropriate depth then for all these: please tag the issues from the PR, please put the tests in a cohesive place. agents can definitely help with that! |
No description provided.