Forbid pathlike DataTree coordinate names#11015
Open
eshort0401 wants to merge 4 commits intopydata:mainfrom
Open
Forbid pathlike DataTree coordinate names#11015eshort0401 wants to merge 4 commits intopydata:mainfrom
eshort0401 wants to merge 4 commits intopydata:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whats-new.rstForbids pathlike coordinate names as a temporary solution before #9485 is fully resolved. This PR is almost the same as the coordinate name checking part of @TomNicholas's PR #9492 from 2024; not sure why this wasn't merged, and happy to update
whats-new.rstauthorship if appropriate! The main difference between this PR and #9492 is a targeted error message when coordinate keys are being checked. Code likewill now produce
I've also amended the
DataTree.coordsandDataTree.data_varsdocstrings to communicate these currently only access the coordinates and variables of the given node, respectively.Notes
This PR follows from discussion in #11001.