Force light mode for notebook outputs#1812
Draft
gabalafou wants to merge 1 commit intopydata:mainfrom
Draft
Conversation
15 tasks
Collaborator
Author
|
Switching to draft mode while I work out the merge conflicts |
Collaborator
|
Should there be an upstream issue in xarray as well ? I'm going to guess this also affect Lab users using dark theme, doesn't it ? |
Collaborator
Author
|
No, it doesn't affect JupyterLab users using dark theme. I think this is because JupyterLab's dark mode CSS is more robust for various widgets than our CSS. See: |
Collaborator
Author
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

If you compare the following screenshots, you will find that the some of the Xarray output is invisible in dark mode.
This PR makes a stronger attempt at forcing notebook outputs into light mode by resetting all of the color variables on the notebook output element to light mode.
Before, screenshots