Conversation
Contributor
|
The TSLint-to-ESLint migration looks right — TSLint has been deprecated for years. The CI lint check fails because the PR itself changes the lint command, which is expected. A few things I noticed:
@rshade want to rebase this against current master? I think it's close to mergeable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the codebase from TSLint to ESLint for TypeScript and JavaScript linting, updates related scripts and configuration, and cleans up obsolete TSLint-specific code. The migration includes introducing a new ESLint configuration, updating CI and Makefile linting commands, and removing TSLint from dependencies and scripts.
Linting migration and configuration:
eslint.config.mjsto enforce code style and quality rules, including copyright headers and stylistic preferences.package.json.tslint.jsonconfiguration file.Build and CI updates:
.github/workflows/test-examples.yml) to install dependencies and use ESLint instead of TSLint for linting.Makefileto remove global TSLint installation, add ESLint-based linting targets, and integrate ESLint into the mainlinttarget. [1] [2]Project scripts and code cleanup:
package.jsonfiles (e.g.,aws-ts-stackreference-architecture/application/package.json,database/package.json,networking/package.json). [1] [2]tslint:disablecomments from TypeScript source files, as ESLint now enforces equivalent rules. [1] [2] [3] [4] [5] [6] [7]