Fix Subdomain Computation of Util function#1629
Open
Armadillidiid wants to merge 1 commit intopulumi:masterfrom
Open
Fix Subdomain Computation of Util function#1629Armadillidiid wants to merge 1 commit intopulumi:masterfrom
Armadillidiid wants to merge 1 commit intopulumi:masterfrom
Conversation
The getDomainAndSubdomain function previously incorrectly computed the subdomain for domain names with multiple subdomains. This commit fixes the computation by properly iterating over the domain parts to extract the subdomain. Additionally, it adds a trailing dot to the parent domain for canonicalization.
|
PR is now waiting for a maintainer to run the acceptance tests. |
Contributor
|
/run-example-tests |
1 similar comment
Contributor
|
/run-example-tests |
dirien
approved these changes
Mar 21, 2026
Contributor
dirien
left a comment
dirien
left a comment
There was a problem hiding this comment.
Clear bug fix for subdomain computation. Single file change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getDomainAndSubdomainfunction previously incorrectly computed the subdomain for domain names with multiple subdomains. This commit fixes the computation by properly iterating over the domain parts to extract the subdomain. Additionally, it adds a trailing dot to the parent domain for canonicalization.