Refactor component loading/finding logic #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-psb
force-pushed
the
feat/add-openapi-spec-find-mechanism
branch
from
e113837 to
f862e0d
Compare
pedro-psb
changed the title
pedro-psb
force-pushed
the
feat/add-openapi-spec-find-mechanism
branch
from
78ff3d2 to
080c1c4
Compare
This is preparing to implement a finding mechansim for the
component openapi-specs.
It creates the following components with more scoped responsabilities:
- ComponentLoader:
Takes a pulp config (in mkdocs.yml pulp plugin section) and return
loaded components with additinal component data (gathered from repos),
as well what plugins were missing.
- RepositoryFinder:
Takes a list of lookup paths and find for a specific repository
following scope rules. E.g only look for pulpcore in pulpcore@/tmp/dir
- DataExtrctor:
Groups methods that should extract extra information from components.
E.g, package versions, git info, etc...
pedro-psb
force-pushed
the
feat/add-openapi-spec-find-mechanism
branch
from
080c1c4 to
ceb2f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparing to implement a finding mechansim for the component openapi-specs.
It creates the following components with more scoped responsabilities:
Takes a pulp config (in mkdocs.yml pulp plugin section) and return loaded components with additinal component data (gathered from repos), as well what plugins were missing.
Takes a list of lookup paths and find for a specific repository following scope rules. E.g only look for pulpcore in pulpcore@/tmp/dir
Groups methods that should extract extra information from components. E.g, package versions, git info, etc...
Closes #177