Skip to content

Hotfix 1.2.1#1665

Open
catch-21 wants to merge 4 commits intomasterfrom
hotfix/1.2.1
Open

Hotfix 1.2.1#1665
catch-21 wants to merge 4 commits intomasterfrom
hotfix/1.2.1

Conversation

@catch-21
Copy link
Copy Markdown
Collaborator

@catch-21 catch-21 commented Apr 8, 2026

…erflow (#1658)

- PostActionsBar: flex-wrap so actions can wrap on narrow widths
- PostMain: drop overflow-y-scroll on actions row (avoid clipping wrapped row)
- theme: BREAKPOINTS.xxs (375) and xs (480) for hooks / responsive checks
- Update snapshots

Made-with: Cursor
@catch-21 catch-21 marked this pull request as draft April 8, 2026 13:53
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 8, 2026

Greptile Summary

This hotfix addresses three distinct layout/scroll regressions: flex-wrap on PostActionsBar prevents horizontal overflow for nested replies, removing overflow-y-scroll from PostMain eliminates the spurious vertical scrollbar, and a new useEffect guard in VisualTimelinePosts auto-paginates through media-free pages so the visual grid never stalls when Virtuoso doesn't fire endReached.

Confidence Score: 5/5

Safe to merge — all three bug fixes are correct and well-scoped; the only finding is a minor dead-code addition.

All remaining findings are P2. The unused breakpoints in theme.ts are a style/dead-code concern that does not affect runtime behavior, correctness, or security.

src/config/theme.ts — unused xxs/xs breakpoints should be removed or wired up

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename Overview
src/components/organisms/Timeline/Feed/TimelineFeed/VisualTimelinePosts.tsx Adds a useEffect-based auto-pagination guard: when a fetched page contains no media tiles (so rows.length stays flat), Virtuoso never fires endReached again; the effect detects the stall and calls loadMore() until rows grow or hasMore is false.
src/components/organisms/PostMain/PostMain.tsx Removes overflow-y-scroll from the PostActionsBar className to fix the spurious vertical scrollbar/overflow introduced in the previous release.
src/components/organisms/PostActionsBar/PostActionsBar.tsx Adds flex-wrap to the actions container to prevent horizontal overflow on narrow screens; renames buttonClassName to btnClassName in destructuring to avoid variable shadowing with the outer buttonClassName const.
src/config/theme.ts Adds xxs: 375 and xs: 480 breakpoints to BREAKPOINTS; neither value is referenced anywhere in the codebase yet, making them effectively dead configuration.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[VisualTimelinePosts renders] --> B{loading?}
    B -- yes --> C[Reset stableRowCountRef = 0]
    B -- no --> D{loadingMore OR error\nOR !hasMore OR hasPendingTiles\nOR postIds empty?}
    D -- yes --> E[Bail — do nothing]
    D -- no --> F{rows.length <=\nstableRowCountRef?}
    F -- yes --> G[Call loadMore]
    G --> H[loadingMore = true\nnext effect run bails]
    H --> I[loadingMore = false\neffect re-evaluates]
    I --> F
    F -- no --> J[Update stableRowCountRef = rows.length]
    J --> K[Virtuoso endReached fires normally]
Loading

Reviews (2): Last reviewed commit: "fix(timeline): auto-paginate visual feed..." | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

🚀 Preview Deployment

URL: https://franky-preview-pr-1665-fzxmjul7ya-oa.a.run.app

franky-preview-pr-1665a08e5d0

Virtuoso's endReached callback only fires when the user scrolls past
rendered items. When a stream page contains only text/link posts, the
visual grid produces no new rows and Virtuoso never re-fires, stalling
pagination. Track the stable row count and auto-load the next page
whenever a completed fetch didn't grow the grid.

Closes: #1661

Co-authored-by: V <jovanovicv90@gmail.com>
@catch-21 catch-21 marked this pull request as ready for review April 8, 2026 14:48
* tests: visual layout e2e

* tests: refactor

* tests: fix gt -> gte

* tests: fix visual layout e2e
secondl1ght
secondl1ght previously approved these changes Apr 9, 2026
@catch-21
Copy link
Copy Markdown
Collaborator Author

catch-21 commented Apr 9, 2026

Waiting for fix for #1678

* fix: visual layout not showing when fresh db or low filter result count

* fix: always show all posts in global content 'All'

* chore: format
@catch-21
Copy link
Copy Markdown
Collaborator Author

Waiting for #1688 to revert Virtuoso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants