Open
Conversation
In Python 3, when __eq__ is defined, Python automatically provides __ne__ by negating __eq__. Explicitly defining __ne__ is redundant and unnecessary code. This removes the redundant __ne__ methods from HTTPBasicAuth and HTTPDigestAuth classes. All existing tests pass, confirming that Python's automatic __ne__ implementation works correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Python 3, when
__eq__is defined, Python automatically provides__ne__by negating__eq__. Explicitly defining__ne__is redundant and unnecessary code.Changes
__ne__method fromHTTPBasicAuthclass__ne__method fromHTTPDigestAuthclassTesting
All existing authentication tests pass (50 tests), confirming that Python's automatic
__ne__implementation works correctly:Benefits