Add __main_void to NullVM.#517
Merged
PiotrSikora merged 2 commits intoproxy-wasm:mainfrom Mar 10, 2026
Merged
Conversation
PiotrSikora
requested review from
leonm1,
martijneken and
mpwarres
as code owners
Missed in proxy-wasm#500, fixes proxy-wasm#516. Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
PiotrSikora
force-pushed
the
main_void_nullvm
branch
from
0dfee2a to
90f3d1a
Compare
Member
Author
Contributor
|
Works on my end, thanks @PiotrSikora ! I'd like to add a test for this to increase our coverage, but I'll merge this as-is since main is currently broken. |
leonm1
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed in #500, fixes #516.