Skip to content

Revert "Make the maximum number of backtrace frames configurable."#515

Open
leonm1 wants to merge 1 commit intomainfrom
revert-499-backtrace_limit
Open

Revert "Make the maximum number of backtrace frames configurable."#515
leonm1 wants to merge 1 commit intomainfrom
revert-499-backtrace_limit

Conversation

@leonm1
Copy link
Contributor

@leonm1 leonm1 commented Mar 10, 2026

Reverts #499.

The number of stack frames to capture is fixed at 10 in V8: v8/v8@5e46b28.

…)"

This reverts commit ad71f14.

Signed-off-by: Matt Leon <mattleon@google.com>
@leonm1 leonm1 force-pushed the revert-499-backtrace_limit branch from fd54bd3 to 157a568 Compare March 10, 2026 14:11
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change definitely works, see:

[ RUN      ] WasmEngines/TestVm.Trap/v8
TRACE from integration: [host->vm] trigger()
ERROR from integration: Function: trigger failed: Uncaught RuntimeError: unreachable
Proxy-Wasm plugin in-VM backtrace:
  0:  0x17a8 - _RNvCsdBezzDwma51_7___rustc12___rust_abort
  1:  0x200 - _RNvCsdBezzDwma51_7___rustc18___rust_start_panic
  2:  0x20e - _RNvCsdBezzDwma51_7___rustc10rust_panic
  3:  0x2802 - std::panicking::panic_with_hook::h51c5edeeb48e69d3
  4:  0x257e - std::panicking::begin_panic::_$u7b$$u7b$closure$u7d$$u7d$::he40991d1daf020e4
  5:  0x2543 - std::sys::backtrace::__rust_end_short_backtrace::haadd8ba7ebd902fa
  6:  0x26ea - std::panicking::begin_panic::h3650af640422e449
  7:  0x192 - _wasm_trap_wasm::five::h98898f90f3e1f7d2
  8:  0x19c - _wasm_trap_wasm::four::h0d3da2cec17003a8
  9:  0x17a - _wasm_trap_wasm::three::h2cc0537245992bde
 10:  0x170 - _wasm_trap_wasm::two::h8d62b9963e06f5ba
 11:  0x166 - _wasm_trap_wasm::one::h027a3f589f2f611c
 12:  0x1b0 - trigger
[       OK ] WasmEngines/TestVm.Trap/v8 (117 ms)

I think those tests pass now anyway, because we look for one which currently would be frame number 9, so it's included even with the default limit of 10.

I've extended the function chain in #518. PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants