Skip to content

Use rust_shared_library for building Wasm modules. #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PiotrSikora wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use rust_shared_library for building Wasm modules. #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions bazel/external/rules_rust.patch
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,6 @@ def proxy_wasm_cpp_host_repositories():
name = "rules_rust",
integrity = "sha256-u8dkwlLQYSgbI1knek1GSA4tz69yr8HObgCtpYzL/Uw=",
urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.69.0/rules_rust-0.69.0.tar.gz"],
patches = ["@proxy_wasm_cpp_host//bazel/external:rules_rust.patch"],
patch_args = ["-p1"],
)

# Core deps. Keep them updated.
Expand Down
6 changes: 2 additions & 4 deletions bazel/wasm.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

load("@rules_rust//rust:defs.bzl", "rust_binary")
load("@rules_rust//rust:defs.bzl", "rust_shared_library")

def _wasm_rust_transition_impl(settings, attr):
return {
Expand Down Expand Up @@ -81,11 +81,9 @@ def wasm_rust_binary(name, tags = [], wasi = False, signing_key = [], **kwargs):
wasm_name = "_wasm_" + name.replace(".", "_")
kwargs.setdefault("visibility", ["//visibility:public"])

rust_binary(
rust_shared_library(
name = wasm_name,
edition = "2018",
crate_type = "cdylib",
out_binary = True,
tags = ["manual"],
**kwargs
)
Expand Down
Loading