Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
2b77ebe
Removed unused imports
GuillaumeLeroy34 Feb 19, 2026
8a3f0a7
commented unused feature that would allow to change the display type …
GuillaumeLeroy34 Feb 19, 2026
9a4ab97
Fixed logger incorrectly logging the error instead of it's message at…
GuillaumeLeroy34 Feb 19, 2026
4f2da10
removed unused test page
GuillaumeLeroy34 Feb 19, 2026
d6c1161
correctly typed index, previous "type" was int instead of number
GuillaumeLeroy34 Feb 19, 2026
086c09e
removed unused import
GuillaumeLeroy34 Feb 19, 2026
fba500b
removed unused websocket for gama system
GuillaumeLeroy34 Feb 19, 2026
3c3dfad
changed the type of message back to any from a string
GuillaumeLeroy34 Feb 19, 2026
897f3d9
retyped from int to number
GuillaumeLeroy34 Feb 19, 2026
a192a0f
fixed typo
GuillaumeLeroy34 Feb 19, 2026
a3feda4
used proper template syntax
GuillaumeLeroy34 Feb 19, 2026
83f45c9
allowed subprojectsList to be empty, as initialization is asynchronou…
GuillaumeLeroy34 Feb 19, 2026
a34ad2b
Moved logger definition in proper scope
GuillaumeLeroy34 Feb 19, 2026
6da9f3c
removed unnecessary @ts-expect-error
GuillaumeLeroy34 Feb 19, 2026
62a1025
added expect error, error is invalid
GuillaumeLeroy34 Feb 19, 2026
156801f
reformated
GuillaumeLeroy34 Feb 19, 2026
fe648aa
removed / fixed unused imports
GuillaumeLeroy34 Feb 19, 2026
95f1164
implemented logger in this component, added a if else block for tailw…
GuillaumeLeroy34 Feb 19, 2026
9711f37
added optionnal property to tailwindcanvas dim
GuillaumeLeroy34 Feb 20, 2026
d9d3c9d
Removed "streamplayerscreenControl" component, as it is currently unu…
GuillaumeLeroy34 Feb 20, 2026
a3a9a26
fixed wrong declaration of logger
GuillaumeLeroy34 Feb 20, 2026
aef2665
added ternary operator, checking if selectadPlayer is not undefined b…
GuillaumeLeroy34 Feb 20, 2026
3f0d3f8
fixed syntax highlighting not working properly, updated eslint depend…
GuillaumeLeroy34 Feb 20, 2026
4c291f6
updated package and package.lock
GuillaumeLeroy34 Feb 20, 2026
f359aaf
added expect error on a value that was identified as unused, but was …
GuillaumeLeroy34 Feb 20, 2026
ac9fe0c
added "entries" property of type array of simulation for proper typin…
GuillaumeLeroy34 Feb 20, 2026
7099bb7
added comments on 2 potentially obscure functions
GuillaumeLeroy34 Feb 20, 2026
f708a4f
changed how subProjectsList is implemented: instead of using [array] …
GuillaumeLeroy34 Feb 20, 2026
e9f2db2
created an error object to properly display an error message in the c…
GuillaumeLeroy34 Feb 20, 2026
1e7b2c6
removed unused "setIdentifier" from the useSearchParams() function
GuillaumeLeroy34 Feb 20, 2026
07e9729
removed unused screen display type functionnality, removed different …
GuillaumeLeroy34 Feb 20, 2026
d7a9f77
added bracket for correct template syntax
GuillaumeLeroy34 Feb 20, 2026
6f57254
added brackets for correct use of logger
GuillaumeLeroy34 Feb 20, 2026
138183c
Simplified the subprojectList: now use an effect hook to update the s…
GuillaumeLeroy34 Feb 23, 2026
c976ed9
converted style attribute containing css to tailwind utilities to red…
GuillaumeLeroy34 Feb 23, 2026
73687a7
Uniformized spacing
GuillaumeLeroy34 Feb 23, 2026
d5a935f
Removed unused commented code
GuillaumeLeroy34 Feb 23, 2026
ee0b1e6
changed to using and operator instead of the ternary operator
GuillaumeLeroy34 Feb 23, 2026
1f80158
added an else clause to fix the issue where the simulation list did n…
GuillaumeLeroy34 Feb 23, 2026
86d5407
removed 'style attribute', and replaced it by an image that is easie…
GuillaumeLeroy34 Feb 23, 2026
b64fd60
removed uncessary ternary operator, and replaced them by an and opera…
GuillaumeLeroy34 Feb 23, 2026
48a13cd
removed eslint exception
GuillaumeLeroy34 Feb 23, 2026
2cf61ff
removed unsued code adding text in the buttons of the simulation flow…
GuillaumeLeroy34 Feb 23, 2026
848da73
removed weird tailwind class
GuillaumeLeroy34 Feb 23, 2026
997896f
added template in the string in the info logs
GuillaumeLeroy34 Feb 23, 2026
18f836b
removed package, package-lock and eslint.config from the .gitignore
GuillaumeLeroy34 Feb 23, 2026
9953431
removed commented useless code and empty space at the top of the comp…
GuillaumeLeroy34 Feb 23, 2026
180b7e4
removed Simulation interface from SelectorSimulation, and replaced it…
GuillaumeLeroy34 Feb 24, 2026
ccbe08f
since we now use properly defined types, we can check the type of the…
GuillaumeLeroy34 Feb 24, 2026
9969041
defined a constant "catalog_item" in the scope of the if to tell ts t…
GuillaumeLeroy34 Feb 24, 2026
3405b49
removed weird conditionnal check that was used to see if an item cont…
GuillaumeLeroy34 Feb 24, 2026
dd01c9f
removed unecessary check, as subprojectlist is always initialized as …
GuillaumeLeroy34 Feb 24, 2026
b8c351a
removed the interface Simulation, implemented the interface VU_CATALO…
GuillaumeLeroy34 Feb 24, 2026
c6ee96d
changed the log to use the error message instead of directly dumping …
GuillaumeLeroy34 Feb 24, 2026
d82be01
removed Simulation from the constants file.
GuillaumeLeroy34 Feb 24, 2026
4c4b79b
removed Simulation and replaced it with VU_MODEL_SETTING_JSON | VU_CA…
GuillaumeLeroy34 Feb 24, 2026
ca2805f
removed useless header from the streaming page
GuillaumeLeroy34 Feb 24, 2026
65d644e
Fixed logger having an incorrect category attribute, and removed unec…
GuillaumeLeroy34 Feb 26, 2026
0b54c61
added comment explaining the eslint config file, removed deprecated .…
GuillaumeLeroy34 Feb 27, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .eslintrc.cjs

This file was deleted.

12 changes: 12 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// new configuration file for eslint, the old .cjs was deprecated
import js from "@eslint/js";
import globals from "globals";
import tseslint from "typescript-eslint";
import pluginReact from "eslint-plugin-react";
import { defineConfig } from "eslint/config";

export default defineConfig([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments to explain how you configured ESLint as it's a bit complicated to read as is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used "npm init @eslint/config@latest" as per the official documentation, followed the steps in the terminal, which ended up making this configuration file. I didn't write it by hand, nor should we read it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot directly answer to the comment, but since the types are not proper classes but instead instances, it would require implementing type guard functions as using instanceof is not possible since interfaces are ditched at runtime. As per the official typescript documentation, this would require creating a function that will also just check the type attribute of the interface.

A cleaner implementation (using instanceof) would require classes, which would make the constant file bigger and heavier, I think that the current system is a good compromise.

{ files: ["**/*.{js,mjs,cjs,ts,mts,cts,jsx,tsx}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: {...globals.browser, ...globals.node} } },
tseslint.configs.recommended,
pluginReact.configs.flat.recommended,
]);
Loading