fix: avoid adding parens to static property in new expression#2453
Open
fs0414 wants to merge 2 commits intoprettier:mainfrom
Open
fix: avoid adding parens to static property in new expression#2453fs0414 wants to merge 2 commits intoprettier:mainfrom
fs0414 wants to merge 2 commits intoprettier:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2441
When formatting code like
new Yii::$app->class([]), the formatter was incorrectly adding parentheses to producenew Yii::$app()->class([]). This changes the semantics from accessing a static property (Yii::$app) to calling a static method (Yii::$app()).Changes
printer.mjsto skip adding parentheses fornewexpressions when:newis inside a member chain (parent is a lookup node or call)staticlookup(e.g.,Yii::$app)Test plan
tests/parens/new.phpfor Issue Bug: Prettier incorrectly adds parentheses when using new with a static property #2441