Open
Conversation
rkaminsk
approved these changes
Apr 10, 2026
| col += 1 | ||
| self.start_cols[sheet] = col | ||
| for setting in range(self.setting_n): | ||
| # pre-create all columns of the current table block with object dtype. |
Member
There was a problem hiding this comment.
I have to admit that I do not have the slightest idea what kind of columns are created here. The number 4 seems a bit of a magic number to me. The typical guideline would be to such constants a descriptive name.
Collaborator
Author
There was a problem hiding this comment.
These are the columns for index, sorted, index and aggregated.
I write your comment down for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.