[evm]: Upgrade solidity-merkle-trees to v0.5.0#754
Open
dharjeezy wants to merge 5 commits intorelayer-v2from
Open
[evm]: Upgrade solidity-merkle-trees to v0.5.0#754dharjeezy wants to merge 5 commits intorelayer-v2from
dharjeezy wants to merge 5 commits intorelayer-v2from
Conversation
dharjeezy
requested review from
Wizdave97 and
seunlanlege
and removed request for
seunlanlege
seunlanlege
approved these changes
Apr 6, 2026
seunlanlege
reviewed
Apr 6, 2026
Member
|
I think you should calculate the positions offchain. Look at the Readme for solidity-merkle-trees for more info |
seunlanlege
reviewed
Apr 8, 2026
seunlanlege
reviewed
Apr 8, 2026
seunlanlege
reviewed
Apr 8, 2026
seunlanlege
approved these changes
Apr 8, 2026
seunlanlege
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrade to solidity-merkle-trees v0.5.0 which internalizes k-index computation, removing it from the public API, it also propagate the removal across handler message types, beefy consensus, prover, verifier, and relayer.