Skip to content

FIX / Consumed credits visibility on tickets for read-only users#221

Open
Mary-Clb wants to merge 2 commits intomainfrom
fix/credit-ticket-readonly-visibility-v2
Open

FIX / Consumed credits visibility on tickets for read-only users#221
Mary-Clb wants to merge 2 commits intomainfrom
fix/credit-ticket-readonly-visibility-v2

Conversation

@Mary-Clb
Copy link
Copy Markdown
Contributor

  • I have performed a self-review of my code.

  • I have added tests (when available) that prove my fix is effective or that my feature works.

  • I have updated the CHANGELOG with a short functional description of the fix or new feature.

  • This change requires a documentation update.

  • It fixes !42948

  • After upgrading from GLPI 10 to GLPI 11.0.6, technician profiles (with plugin rights enabled) could no longer reliably see consumed credits on tickets. Consumed credits rendering was coupled with ticket editability (canedit), which could hide data in read-only contexts. In addition, the credit form JavaScript used broad DOM targeting, making it sensitive to Twig render order and page structure.

@Mary-Clb Mary-Clb marked this pull request as ready for review March 30, 2026 08:44
@Mary-Clb Mary-Clb requested a review from stonebuzz March 30, 2026 08:44
Copy link
Copy Markdown
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting customer validation

@Mary-Clb
Copy link
Copy Markdown
Contributor Author

Mary-Clb commented Apr 8, 2026

Customer didn't approve : credit vouchers list still unavailable on entity tab from tech profile.

  • Modify the view so credit tab can be visible even if user can't edit the entity

@Mary-Clb Mary-Clb requested review from Rom1-B and stonebuzz April 8, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants